Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] return ErrMaxConcurrentOpsReached when too many concurrent ops in transaction coordinator client #1242

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

RobertIndie
Copy link
Member

@RobertIndie RobertIndie commented Jul 11, 2024

Motivation

Currently, the client will return an UnknownError when there are too many concurrent ops in transaction coordinator client

Modifications

  • Add new error ErrMaxConcurrentOpsReached
  • Return ErrMaxConcurrentOpsReached when too many concurrent ops in transaction coordinator client

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie added this to the v0.13.0 milestone Jul 11, 2024
@RobertIndie RobertIndie self-assigned this Jul 11, 2024
@BewareMyPower
Copy link
Contributor

Please fix the conflicts with master

@RobertIndie RobertIndie merged commit e7a771f into apache:master Jul 11, 2024
7 checks passed
@RobertIndie RobertIndie deleted the improve-txn-error branch July 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants