-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor][schema] replace linkedin/goavro/v2 with hamba/avro/v2 #1230
Conversation
8c3e16a
to
a65fddd
Compare
Starting from #1191 |
3818d0d
to
e4aecab
Compare
e4aecab
to
840abe2
Compare
Rethinking recent changes, due to you changing some method parameters, it appears that there is a breaking change, which resulted in me making an incorrect review. In the old design, the codec was exported in the schema, and which was created by NewSchemaDefinition(should be internal). Usually, the users use the following methods to create the avro schema: NewAvroSchema()
NewAvroSchemaWithValidation() So that we can remove NewSchemaDefinition and AvroCodec. The next version is the minor version, we can make this changes. BTW, newXXSchema method returns an implement, not an interface, we also need to improve that in the future. Is this a fair reason? |
@nodece fair & done |
Motivation
Allow direct deserialization in go struct, allow generation of go struct using avro schema <- support offered by hamba/avro
Improved support in hamba avro project, while linkedin has limited support since 2022
Modifications
Replaced linkedin/goavro/v2 with hamba/avro/v2
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation