[fix][build] Build test container image using current hardware platform #1205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test container image is built for
amd64
platforms only. This makes it difficult to test and run on others, notably Apple Silicon chips runningarm64
.Modifications
The source of the problem is using the hardcoded
amd64
Go binary distribution during the image build. On Apple Silicon, runningmake test
yields the following error:Sourcing the local platform name from
uname -m
and using it to download the corresponding Go distribution solves the issue:Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation