Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][TableView] Correct argument order to Errorf in TableView message handling #1130

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ojcm
Copy link
Contributor

@ojcm ojcm commented Nov 14, 2023

Motivation

When TableView fails to read a message with the schema the error message is malformed, e.g.

ERRO[0000] msg.GetSchemaValue() failed with %!w(*pulsar.message=&{[..snipped..]}); msg is schema not found for topic: [..snipped..], schema version : [ [0 0 0 0 0 0 0 0] ]

The correct formatting will help users to debug their issues.

Modifications

Switch error args to match the formatting directives and context of the message.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why? Trivial error formatting fix
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@ojcm ojcm changed the title [fix][TableView Correct argument order to Errorf in TableView message handling [fix][TableView] Correct argument order to Errorf in TableView message handling Nov 14, 2023
@RobertIndie RobertIndie merged commit c91a800 into apache:master Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants