[fix] Fix flaky test in negative_acks_tracker_test.go
#1017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1016
Motivation
The test for negative ack trackers needs to wait sometime to close the message channel. We use this interval time to assert that the negativeAckTracker can trigger the redelivering with the correct time interval. But we can't assert this interval very precisely due to the concurrent execution. Currently, we reserve only one millisecond for this concurrent execution:
pulsar-client-go/pulsar/negative_acks_tracker_test.go
Lines 45 to 49 in 3367cc0
Here, 100 milliseconds is for the client tick delay. But we only wait for another 1 millisecond. This seems too short and introduces the flaky.
This PR waits for more 200 milliseconds. This will not affect the correctness of the test. Because the minimum interval NackDelay we used in these tests is 300 milliseconds. Waiting more 200 milliseconds will not affect the test result.
Modifications
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation