Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plc4j/ads): Add STRING and WSTRING to getDataTypeTableEntry. #1902

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

fdupont-epsilia
Copy link
Contributor

Add STRING and WSTRING to getDataTypeTableEntry.
serializePlcValue, remove check directly in dataTypeTable, only use getDataTypeTableEntry.

…emove check directly in dataTypeTable, only use getDataTypeTableEntry.
@sruehl sruehl requested a review from chrisdutz November 20, 2024 12:20
@fdupont-epsilia fdupont-epsilia changed the title Add STRING and WSTRING to getDataTypeTableEntry. feat(plc4j/ads): Add STRING and WSTRING to getDataTypeTableEntry. Nov 21, 2024
@fdupont-epsilia
Copy link
Contributor Author

Could this Pull Request be merged? Considering ADS works, and no modification in opcua.

test (21, ubuntu-latest)

[INFO] Protocols: ADS ..................................... SUCCESS [  2.192 s]
[INFO] PLC4J: Driver: ADS ................................. SUCCESS [ 12.046 s]

[INFO] PLC4J: Driver: OPC UA .............................. FAILURE [09:20 min]

Error:  Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on project plc4j-driver-opcua: 

2024-11-19 20:03:54,327 ERROR | nioEventLoopGroup-123-1 | o.a.plc4x.java.opcua.protocol.OpcuaSubscriptionHandle   | Invalid Tag Integer, subscription created without this tag 
2024-11-19 20:03:55,295  WARN | nioEventLoopGroup-123-1 | o.a.plc4x.java.opcua.protocol.OpcuaSubscriptionHandle   | Publish request of subscription 1 resulted in error reported by server 
java.util.concurrent.CompletionException: org.apache.plc4x.java.api.exceptions.PlcInvalidTagException: Integer invalid

@chrisdutz
Copy link
Contributor

Looks good to me ... haven't had the time to test it in my setup, but I wouldn't want to block merging this for that reason.

@sruehl sruehl merged commit 3260c07 into apache:develop Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants