Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced a new optional "slaveId" parameter to the modbus driver #118

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

acs
Copy link

@acs acs commented Feb 11, 2020

No description provided.

@acs acs requested a review from chrisdutz February 11, 2020 09:28
@acs
Copy link
Author

acs commented Feb 11, 2020

This code was not merged in develop branch and it is needed. With this PR we do it! Thanks @chrisdutz for the code and my fault not reporting after two days the results for the testing (I did it in the PLC4x ticket: https://issues.apache.org/jira/projects/PLC4X/issues/PLC4X-156) blocking the merging of this code.

@acs acs merged commit 4958efd into develop Feb 12, 2020
@asfgit asfgit deleted the issue/PLC4X-156 branch February 3, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants