Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixgeode PdxEncoder/Decoder derivation on Scala 3.4+ #748

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

WojciechMazur
Copy link
Contributor

Makes LabelledGeneric.productInst a transparent inline to allow consuming it on Scala 3.4+ due to new constraints introduced by the compiler - see scala/scala3#19253 for more details and scala/scala3#21236 for minimization of problem found in this project.

Without this change users are forced to use -source:3.3 option when building on Scala 3.4 or later.

The problem was found by the Scala 3 Open Community Build - build logs

…nsuming it on Scala 3.4+ due to constraint introduced by the compiler
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@He-Pin He-Pin merged commit 97f10ab into apache:main Jul 19, 2024
51 of 52 checks passed
@pjfanning pjfanning added this to the 1.1.0-M2 milestone Jul 19, 2024
@WojciechMazur WojciechMazur deleted the fix/scala-3.4 branch July 19, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants