Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUTCH-3097 fixed dependencies for indexer-elastic #844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NUTCH-3097 fixed dependencies for indexer-elastic #844

wants to merge 1 commit into from

Conversation

maciejpuzianowski
Copy link

sebastian-nagel
sebastian-nagel approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@sebastian-nagel sebastian-nagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

lewismc
lewismc approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested locally
I think I'll propose a GSoC project which implements integration tests with test containers so improvements of this nature can be more easily validated in CI prior to testing.

lewismc
lewismc approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested locally
I think I'll propose a GSoC project which implements integration tests with test containers so improvements of this nature can be more easily validated in CI prior to local testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-nagel sebastian-nagel sebastian-nagel approved these changes

@lewismc lewismc lewismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciejpuzianowski @lewismc @sebastian-nagel