Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-554] Add ccache reporting to CI #11322

Merged
merged 1 commit into from
Jun 17, 2018

Conversation

KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Jun 17, 2018

Description

Adding some diagnostic ccache output to builds using ccache. This output will allow us to get a sense of both the global level of caching for the system, and will provide diagnostic information for the specific builds via the log files.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

  • I've tried to provide a balance of information so that we can see what is actionable, but we don't fill our logs with verbose output.

@KellenSunderland KellenSunderland force-pushed the ccache_reporting branch 2 times, most recently from 4f1012f to 01c995e Compare June 17, 2018 08:47
@KellenSunderland KellenSunderland changed the title WIP: Add ccache reporting to CI [MXNET-554] Add ccache reporting to CI Jun 17, 2018
@KellenSunderland
Copy link
Contributor Author

@larroy Any tips for this change?

@marcoabreu How's this look for ccache diagnostic info?

@marcoabreu
Copy link
Contributor

marcoabreu commented Jun 17, 2018

I like it general, I'm just afraid it's a bit too verbose since it increases the log by about 300%.

It would be a bit tedious, but we could try to reproduce ccache -s locally by parsing the log. We could aggregate the 'Result' lines:

Result: cache hit (direct)
Result: called for link
Result: no input file

wdyt?

Edit1: It seems like ccache -s is doing exactly that: https://ccache.samba.org/manual.html#_cache_statistics

@KellenSunderland
Copy link
Contributor Author

KellenSunderland commented Jun 17, 2018 via email

@marcoabreu
Copy link
Contributor

Okay, sounds good to me.

@marcoabreu marcoabreu merged commit ef3169a into apache:master Jun 17, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants