Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-514] Add clip_global_norm(row_sparse_grad). Fix row_sparse_param.save(). Fix trainer init_kvstore #11266

Merged
merged 3 commits into from
Jun 18, 2018
Merged

[MXNET-514] Add clip_global_norm(row_sparse_grad). Fix row_sparse_param.save(). Fix trainer init_kvstore #11266

merged 3 commits into from
Jun 18, 2018

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jun 13, 2018 •
edited
Loading

Description

As title. Test cases are updated accordingly.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner June 13, 2018 23:04
@eric-haibin-lin eric-haibin-lin changed the title Add clip_global_norm(row_sparse_grad). Fix row_sparse_param.save() Add clip_global_norm(row_sparse_grad). Fix row_sparse_param.save(). Fix trainer init_kvstore Jun 14, 2018
@eric-haibin-lin eric-haibin-lin changed the title Add clip_global_norm(row_sparse_grad). Fix row_sparse_param.save(). Fix trainer init_kvstore [MXNET-514] Add clip_global_norm(row_sparse_grad). Fix row_sparse_param.save(). Fix trainer init_kvstore Jun 17, 2018
@piiswrong piiswrong merged commit 9226d91 into apache:master Jun 18, 2018
@ThomasDelteil
Copy link
Contributor

ThomasDelteil commented Jun 19, 2018 •
edited
Loading

@eric-haibin-lin I have this test failing in my build on windows, is it flaky or an actual failure you reckon?
test_trainer_reset_kv
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-11332/4/pipeline/752

@eric-haibin-lin
Copy link
Member Author

@ThomasDelteil let me look into it

@eric-haibin-lin
Copy link
Member Author

It's a flaky one. I don't see it fail on master build. Maybe it's to do with param.load/save on windows...

@marcoabreu
Copy link
Contributor

#11353

@szha
Copy link
Member

szha commented Jun 25, 2018

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-11379/1/pipeline

zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@eric-haibin-lin @zheng-da
[MXNET-514] Add clip_global_norm(row_sparse_grad). Fix row_sparse_par…
3868af6 
…am.save(). Fix trainer init_kvstore (apache#11266)

* clip sparse grad. fix _reduce for rowsparse param

* fix kvstore init for local kv

* trigger
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@eric-haibin-lin @piiswrong
[MXNET-514] Add clip_global_norm(row_sparse_grad). Fix row_sparse_par…
d713ffb 
…am.save(). Fix trainer init_kvstore (apache#11266)

* clip sparse grad. fix _reduce for rowsparse param

* fix kvstore init for local kv

* trigger
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@piiswrong piiswrong Awaiting requested review from piiswrong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eric-haibin-lin @ThomasDelteil @marcoabreu @szha @piiswrong