Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-379] L1 Normalization #11229

Merged
merged 30 commits into from
Jun 30, 2018
Merged

Conversation

anirudhacharya
Copy link
Member

@anirudhacharya anirudhacharya commented Jun 11, 2018

Description

l1 norm operator

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • l1 norm

Comments

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also resolve the conflicts

@anirudhacharya
Copy link
Member Author

anirudhacharya commented Jun 28, 2018

@haojin2 @eric-haibin-lin @piiswrong ping for review.

@eric-haibin-lin eric-haibin-lin dismissed their stale review June 29, 2018 16:42

stype inference fixed

@anirudhacharya
Copy link
Member Author

@eric-haibin-lin can you please merge this.

@eric-haibin-lin eric-haibin-lin merged commit f783a66 into apache:master Jun 30, 2018
@anirudhacharya anirudhacharya deleted the norm1 branch June 30, 2018 00:07
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants