Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Intel MKL-DNN RNN Support #10542

Closed
sbodenstein opened this issue Apr 13, 2018 · 14 comments
Closed

Intel MKL-DNN RNN Support #10542

sbodenstein opened this issue Apr 13, 2018 · 14 comments

Comments

@sbodenstein
Copy link
Contributor

MKL-DNN recently got support for RNNs. Are there any plans for adding this as a backend to mx.sym.RNN, and what sort of timeframe? Thanks!

@zheng-da

@TaoLv
Copy link
Member

TaoLv commented Apr 13, 2018

@sbodenstein Thanks for asking that. It's already on our plan list for Q2. Since it's still an experimental interface, we will keep tracking the development progress from mkldnn team.
FYI, we are working intensively on PR #10104 and #10311 to provide fused RNN operator for mxnet before mkldnn RNN interfaces become mature. Hopefully, after mkldnn RNN is integrated into mxnet, code of #10104 and #10311 would still exsit as a reference implementation for cpu. @pengzhao-intel

@Roshrini
Copy link
Member

@eric-haibin-lin Can you please add labels-
FeatureRequest, RNN

@azai91
Copy link
Contributor

azai91 commented Jul 9, 2018

@sbodenstein we plan on implementing MKL-DNN RNN support when MKLDNN 0.15 is released which should be within the next few weeks.

@sbodenstein
Copy link
Contributor Author

@azai91: fantastic, thanks so much!

@neverjoe
Copy link

Any good news for mkl-dnn rnn support?

@pengzhao-intel
Copy link
Contributor

@neverjoe thanks for the asking.
MKL-DNN provides the RNN API now in the new latest (v0.17) and we have upgraded it to MXNet now.
We have the discussion with @szha for the further integration.

Do you mind providing more details about what's your models and feature requests for MKL-DNN?

@neverjoe
Copy link

neverjoe commented Nov 13, 2018 via email

@neverjoe
Copy link

Is there any python test demo for GruForwardInference?

@pengzhao-intel
Copy link
Contributor

There's no python interface, but you can test by mkldnn binary very simple.
https://github.com/intel/mkl-dnn/tree/master/tests/benchdnn

oneapi-src/oneDNN@3ced2c7

./benchdnn --rnn --batch=./inputs/rnn/test_rnn_small

In the test file, it includes several configurations:

--reset --alg=VANILLA_GRU
--direction=left2right
--activation=TANH
--prop=FWD_D --batch=rnn_gru_small
--prop=BWD_DW --batch=rnn_gru_small

@neverjoe
Copy link

neverjoe commented Nov 13, 2018 via email

@anirudh2290
Copy link
Member

@pengzhao-intel Can you point me to the further discussion for MKLDNN RNN API Integration.

@pengzhao-intel
Copy link
Contributor

@anirudh2290 yes, we have the plan but a little complicated mixed the next major release of MXNet 2.0 and MKLDNN 1.0.

We can talk for more details by email, please ping me [email protected]

@bgawrych
Copy link
Contributor

@szha Can we close this issue? MXNet already have support for oneDNN RNN's

@szha szha closed this as completed Jun 30, 2021
@szha
Copy link
Member

szha commented Jun 30, 2021

@bgawrych thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants