Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSHD-1237] Handle keep-alive channel requests #492

Merged
merged 1 commit into from
May 1, 2024

Conversation

tomaswolf
Copy link
Member

@tomaswolf tomaswolf commented Apr 27, 2024

OpenSSH server sends keep-alive requests as channel requests if a channel is open. Handle these channel requests in the "last-resort" channel request handler.

@gnodet
Copy link
Contributor

gnodet commented Apr 28, 2024

OpenSSH server sends keep-alive requests as channel requests if a channel is open. Do not log a warning about such requests, simply send back a failure reply. OpenSSH just expects any reply, whether success or failure.

Not displaying the warning looks weird. Wouldn’t it be cleaner to « support » them instead and reply with a success or failure ?

OpenSSH sends keep-alive requests as channel requests if a channel is
open. It uses a global request only if no channel is open. Handle these
requests in the "last-resort" channel request handler.
@tomaswolf
Copy link
Member Author

Not displaying the warning looks weird. Wouldn’t it be cleaner to « support » them instead and reply with a success or failure ?

Done.

@tomaswolf tomaswolf changed the title [SSHD-1237] Don't warn about keep-alive channel requests [SSHD-1237] Handle keep-alive channel requests Apr 28, 2024
@tomaswolf tomaswolf merged commit fa1dd24 into apache:master May 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants