Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen scope of validateLinks #308

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

michael-o
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o force-pushed the MJAVADOC-792-alternative branch 2 times, most recently from ec08dd2 to d7dbdde Compare August 15, 2024 15:54
@asfgit asfgit force-pushed the MJAVADOC-792-alternative branch from d7dbdde to b2008a7 Compare August 15, 2024 20:17
@michael-o michael-o changed the title Try Widen scope of validateLinks Aug 17, 2024
@michael-o michael-o force-pushed the MJAVADOC-792-alternative branch from b2008a7 to d37a6d4 Compare October 29, 2024 08:55
@michael-o
Copy link
Member Author

@kwin what is your opinion on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant