-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOXIA-618] import tests from maven-site-plugin #52
[DOXIA-618] import tests from maven-site-plugin #52
Conversation
bertysentry
commented
Jan 5, 2021
- doxia-module-markdown: Re-incorporated integration tests from maven-site-plugin
- doxia-module-markdown: Merged DOXIA-616 integration tests into general
@michael-o @hboutemy This PR is in relation with the removal of some integration tests from maven-site-plugin. These tests have been re-incorporated in Doxia so that we make sure to catch potential problems early. Also, this allows us to implement new features or change the behavior of the parsers without having to modify tests that are too picky in maven-site-plugin (or test that are just become irrelevant). |
running through jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-doxia/job/doxia-618/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elharo Yes, this is weird. The build fails... on JDK7 only. To be honest, I don't see what I changed that could possibly break things... on JDK7 and still work in JDK8. |
Perhaps try cutting this up into smaller pieces if possible. |
Builds have been failing on JDK7 since this commit: b55285c There are 2 error messages. First error:
I really don't see what could have triggered this problem. It must be either in MarkdownParser.java or MarkdownParserTest.java But since I haven't touched the component declaration, I don't understand what is wrong here. 2nd error message
This one I understand. The So, this needs to be fixed in a separate issue. Sorry about that! |
Before we spend too much time on this, do we want to spend time on compatibility with Java 7? |
Yes, we absolutely do need to fix this. We have to rollback the offending commit/PR before anything else can move forward. |
Okay, I now understand the problem: the Pattern is compiled as a static constant in MarkdownParser. The Pattern.compile() fails because of the unknown I'll submit a new PR to fix this. How do you trigger builds on Jenkins? We could have caught this before. Thanks! |
Unfortunately only committers can trigger Jenkins builds so you have to ask one of us to do it for you. :-( |
It's okay. I can reproduce the problem locally (and thus fix it). |
* doxia-module-markdown: Re-incorporated integration tests from **maven-site-plugin** * doxia-module-markdown: Merged DOXIA-616 integration tests into **general**
0f6b80f
to
dce37ef
Compare
The branches are a bit confusing but I'm running it through now |
@elharo How is it going? |
Awesome, thank you! |