feat(search): Hnsw Vector Search Optimizaton Pass #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
PragmaTwice
reviewed
Aug 5, 2024
PragmaTwice
reviewed
Aug 5, 2024
There was a problem hiding this comment.
The rest looks good to me!
Also if you have time maybe you can also add some golang test cases for vector search, after this PR is merged.
Beihao-Zhou
changed the title
PragmaTwice
reviewed
Aug 6, 2024
PragmaTwice
reviewed
Aug 6, 2024
PragmaTwice
reviewed
Aug 6, 2024
Beihao-Zhou
commented
Aug 6, 2024
PragmaTwice
approved these changes
Aug 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #2426
Summary
sort bytoknn search exprfor SQL queryFilterexecutor in case that vector range search acts as the prefilter for KNN search