Skip WATCH if connection is already dirty #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a conn is already marked as watched_keys_modified, we can skip the watch. It is a cleanup and in situations it may save us some memory and performance gains.
PragmaTwice
approved these changes
Jul 28, 2023
git-hulk
approved these changes
Jul 28, 2023
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 1, 2023
If a conn is already marked as watched_keys_modified, we can skip the watch. It is a cleanup and in some situations it may save us some memory and performance gains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a conn is already marked as watched_keys_modified,
we can skip the watch. It is a cleanup and in some situations
it may save us some memory and performance gains.