Don't use auto-retry in unit/type/list_test.go #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, go-redis will auto-retry if the request was timeout and it may cause the duplicate push in the list test case. So we need to manually disable it to reduce the possibility of the CI test.
torwig
approved these changes
May 22, 2023
|
Thanks @torwig, merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, go-redis will auto-retry if the request was timeout and it may cause the duplicate push in the list test case. So we need to manually disable it to reduce the possibility of the CI test.
This flaky test wasn't caused by using the same key in multiple test cases, which was resolved in #1449 and still failed frequently. After investigating the test case, the possible reason may be caused by the go-redis auto-retry strategy.