KAFKA-17554: Flaky testFutureCompletionOutsidePoll in ConsumerNetworkClientTest #18298
+3
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-17554
In the previous workflow, the test passes under two conditions:
t1
thread is waiting for the main thread'sclient.wakeup()
. If successful,t1
will wake upt2
, allowingt2
to complete the future.t1
fails to receive theclient.wakeup()
from the main thread,t2
will be woken up by the main thread.In the previous implementation, we used a
CountDownLatch
to control the execution of three threads, but it often led to race conditions. Currently, we have modified it to use two threads to test this scenario.I run
I=0; while ./gradlew :clients:test --tests ConsumerNetworkClientTest.testFutureCompletionOutsidePoll --rerun --fail-fast; do (( I=$I+1 )); echo "Completed run: $I"; sleep 1; done
and pass 3000+ times.Committer Checklist (excluded from commit message)