KAFKA-18295: Remove deprecated function Partitioner#onNewBatch #18282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
force-pushed
the
KAFKA-18295
branch
4 times, most recently
from
1e8b7d5 to
40aa21c
Compare
chia7712
reviewed
Dec 25, 2024
| @@ -1020,9 +1011,6 @@ private Future<RecordMetadata> doSend(ProducerRecord<K, V> record, Callback call | |||
|
|
|||
| if (result.abortForNewBatch) { | |||
| int prevPartition = partition; | |||
| // IMPORTANT NOTE: the following onNewBatch and partition calls should not interrupted to allow | |||
| // the custom partitioner to correctly track its state | |||
| onNewBatch(record.topic(), cluster, prevPartition); | |||
There was a problem hiding this comment.
we don't need the path of "abortOnNewBatch", right? If so, could you please do a bit refactor for it?
There was a problem hiding this comment.
Thanks for the suggestion. Updated it.
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18295
branch
from
40aa21c to
d74add0
Compare
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18295
branch
from
d74add0 to
15a58dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Partitioner#onNewBatchhas been deprecated by KAFKA-10888 since 2022. It can be removed from version 4.0.Committer Checklist (excluded from commit message)