Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-10787: Apply spotless to streams:examples and streams-scala #16378

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

gongxuanzhang
Copy link
Contributor

@gongxuanzhang gongxuanzhang commented Jun 18, 2024

This PR is sub PR from #16097.
It is part of a series of changes to progressively apply [spotless plugin(import-order)] across all modules. In this step, the plugin is activated in the

  • stream:test-utils
  • streams:upgrade-system-tests-0100

Module and history

Please see the table below for the historical changes related to applying the Spotless plugin

module apply related PR
:clients future
:connect:api #16299
:connect:basic-auth-extension #16299
:connect:file #16299
:connect:json #16299
:connect:mirror #16299
:connect:mirror-client #16299
:connect:runtime future
:connect:test-plugins #16299
:connect:transforms #16299
:core future
:examples #16296
:generator #16296
:group-coordinator:group-coordinator-api #16298
:group-coordinator #16298
:jmh-benchmarks #16296
:log4j-appender #16296
:metadata #16297
:server #16297
:shell #16296
:storage #16297
:storage:storage-api #16297
:streams future
:streams:examples #16378
:streams:streams-scala #16378
:streams:test-utils #16357
:streams:upgrade-system-tests-0100 #16357
:streams:upgrade-system-tests-0101 #16357
:streams:upgrade-system-tests-0102 #16357
:streams:upgrade-system-tests-0110 #16357
:streams:upgrade-system-tests-10 #16357
:streams:upgrade-system-tests-11 #16357
:streams:upgrade-system-tests-20 #16357
:streams:upgrade-system-tests-21 #16357
:streams:upgrade-system-tests-22 #16357
:streams:upgrade-system-tests-23 #16357
:streams:upgrade-system-tests-24 #16357
:streams:upgrade-system-tests-25 #16357
:streams:upgrade-system-tests-26 #16357
:streams:upgrade-system-tests-27 #16357
:streams:upgrade-system-tests-28 #16357
:streams:upgrade-system-tests-30 #16357
:streams:upgrade-system-tests-31 #16357
:streams:upgrade-system-tests-32 #16357
:streams:upgrade-system-tests-33 #16357
:streams:upgrade-system-tests-34 #16357
:streams:upgrade-system-tests-35 #16357
:streams:upgrade-system-tests-36 #16357
:streams:upgrade-system-tests-37 #16357
:trogdor #16296
:raft #16278
:server-common #16172
:transaction-coordinator #16172
:tools #16262
:tools:tools-api #16262

How to test:

We can run ./gradlew spotlessCheck check for code that does not meet requirements.
If we get report that error , we can run ./gradlew spotlessApply to review my code.
In this PR, all change(exclude build.gradle) byspotlessApply`

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 5a331ac into apache:trunk Jun 18, 2024
1 check failed
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants