KAFKA-15776: Support added to update remote.fetch.max.wait.ms dynamically #16203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
showuon
reviewed
Jun 6, 2024
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
Outdated
Show resolved
Hide resolved
satishd
reviewed
Jun 7, 2024
| assertThrows(classOf[ConfigException], () => config.dynamicConfig.validate(newProps, perBrokerConfig = false)) | ||
| // invalid value "0" | ||
| newProps.put(RemoteLogManagerConfig.REMOTE_FETCH_MAX_WAIT_MS_PROP, "0") | ||
| assertThrows(classOf[ConfigException], () => config.dynamicConfig.validate(newProps, perBrokerConfig = true)) |
There was a problem hiding this comment.
Can you also check perBrokerConfig = false for value 0 like you did for negative value -1 in the earlier code?
|
A few test failures that are unrelated to this change, will merge it to trunk and 3.8 branches. |
|
@kamalcph Can you raise a PR against 3.8 branch as I would like those changes to be reviewed in PR as it has conflicts with that branch? |
kamalcph
added a commit
to kamalcph/kafka
that referenced
this pull request
Jun 11, 2024
…ally (apache#16203) Reviewers: Satish Duggana <[email protected]>, Luke Chen <[email protected]>
Opened #16275 and #16276 to cherry-pick the KAFKA-15776 feature to the 3.8 branch. PTAL. |
satishd
pushed a commit
that referenced
this pull request
Jun 11, 2024
…ally (#16203) Reviewers: Satish Duggana <[email protected]>, Luke Chen <[email protected]>
3 tasks
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…ally (apache#16203) Reviewers: Satish Duggana <[email protected]>, Luke Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)