Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure #1861

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure #1861

wants to merge 1 commit into from

Conversation

andreeastroe96
Copy link

No description provided.

@kwin
Copy link
Member

kwin commented Nov 13, 2024

Every larger PR needs a JIRA ticket in https://issues.apache.org/jira/projects/OAK!

@andreeastroe96
Copy link
Author

Every larger PR needs a JIRA ticket in https://issues.apache.org/jira/projects/OAK!

Hi! I linked this PR with this JIRA issue: https://issues.apache.org/jira/browse/OAK-11267 . Please let me know if something else is required.

@kwin
Copy link
Member

kwin commented Nov 13, 2024

Every larger PR needs a JIRA ticket in https://issues.apache.org/jira/projects/OAK!

Hi! I linked this PR with this JIRA issue: https://issues.apache.org/jira/browse/OAK-11267 . Please let me know if something else is required.

Please read https://jackrabbit.apache.org/oak/docs/participating.html. Currently the commit message does not reference the Oak issue.

@andreeastroe96 andreeastroe96 changed the title GRANITE-53956 Upgrade Azure SDK V8 to V12 for oak-blob-azure OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure Nov 13, 2024
@anchela
Copy link
Contributor

anchela commented Nov 13, 2024

@kwin , maybe it's just style.... but to me your review comments don't come across as welcoming (see https://apache.org/foundation/policies/conduct). @andreeastroe96 is a new contributor to the project and there is IMHO no need to be angry... a friendly reminder will do magic.

@kwin
Copy link
Member

kwin commented Nov 13, 2024

@anchela You are right.
@andreeastroe96 Sorry, if I came across rude. That was not intended. Just be aware that this is the ASF Jackrabbit context so neither AEM nor GRANITE nor any other restricted references should be used here for everyone to be able to follow/review accordingly. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ierandra ierandra ierandra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreeastroe96 @kwin @anchela @ierandra