bugfix: fix tablemeta refresh after closed #7044
Merged
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7044 +/- ##
============================================
- Coverage 52.77% 52.75% -0.02%
- Complexity 6639 6640 +1
============================================
Files 1126 1126
Lines 40107 40122 +15
Branches 4697 4700 +3
============================================
+ Hits 21167 21168 +1
- Misses 16928 16944 +16
+ Partials 2012 2010 -2
|
funky-eyes
reviewed
Dec 3, 2024
| * @param ex the SQLException to check | ||
| * @return true if the exception indicates the data source is closed; false otherwise | ||
| */ | ||
| private boolean isDataSourceClosedException(SQLException ex) { |
There was a problem hiding this comment.
If it's just the connection being closed, can the two be distinguished?
There was a problem hiding this comment.
use sqlState 08006 and exception message keywords to distinguish
funky-eyes
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of the property
client.rm.tableMetaCheckEnableshould be changed tofalseto align with the behavior of Seata Client 2.1.0 and earlier #7042Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews