Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pointer of Continuation's headerBuffer after copying the payload #507

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

CoolTomatos
Copy link
Contributor

This pull request fixes HTTPCORE-772

@ok2c
Copy link
Member

ok2c commented Nov 26, 2024

@CoolTomatos There are style violations that need to be fixed.

Ideally it would be nice to have a test case for this defect added to TestAbstractH2StreamMultiplexer but I will accept the PR without it.

@CoolTomatos
Copy link
Contributor Author

Hi @ok2c, thanks for the reply.
Just pushed a commit to fix the style issue.
Will try to add some test coverage tomorrow. Was looking at APIs how to setup some header frames and continuation frames for the test case.

@CoolTomatos
Copy link
Contributor Author

Hi @ok2c added a small test case that would fail without my fix and passes with my fix. Please have a look!

@ok2c ok2c merged commit 191097a into apache:master Nov 27, 2024
10 checks passed
@ok2c
Copy link
Member

ok2c commented Nov 27, 2024

@CoolTomatos cherry-picked to 5.3.x

@CoolTomatos
Copy link
Contributor Author

@CoolTomatos cherry-picked to 5.3.x

Hi @ok2c do we have a rough timeline when 5.3.2 will be released?

@ok2c
Copy link
Member

ok2c commented Nov 27, 2024

@CoolTomatos It is a nasty one but not severe enough for an emergency release in my opinion. I would release 5.3.2 sometime in January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants