Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies with no license #3790

Closed
ralf0131 opened this issue Apr 2, 2019 · 4 comments
Closed

Dependencies with no license #3790

ralf0131 opened this issue Apr 2, 2019 · 4 comments
Assignees
Milestone

Comments

@ralf0131
Copy link
Contributor

ralf0131 commented Apr 2, 2019

When examine the license file of Dubbo dependencies, the following command is executed:

 mvn license:add-third-party -Dlicense.useMissingFile -Dlicense.includeOptional=true

The following output shows there are 2 dependencies with no license:

[INFO] Missing file ~/work/apache-dubbo/incubator-dubbo/dubbo-registry/dubbo-registry-nacos/src/license/THIRD-PARTY.properties is up-to-date.
[WARNING] There are 2 dependencies with no license :
[WARNING]  - javax.xml.bind--jsr173_api--1.0
[WARNING]  - net.jcip--jcip-annotations--1.0

Need to check the actually license of the two dependencies, to see if it is compatible with Dubbo.

Below is a partial output of the mvn dependency:tree in the dubbo-registry-nacos module.

[INFO] +- org.jboss.resteasy:resteasy-jaxrs:jar:3.0.19.Final:test
[INFO] |  +- org.jboss.spec.javax.ws.rs:jboss-jaxrs-api_2.0_spec:jar:1.0.0.Final:test
[INFO] |  +- org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar:1.0.0.Final:test
[INFO] |  +- javax.activation:activation:jar:1.1.1:test
[INFO] |  +- org.apache.httpcomponents:httpclient:jar:4.5.3:test
[INFO] |  |  \- org.apache.httpcomponents:httpcore:jar:4.4.6:test
[INFO] |  +- commons-io:commons-io:jar:2.1:compile
[INFO] |  +- net.jcip:jcip-annotations:jar:1.0:test
[INFO] |  \- org.jboss.logging:jboss-logging:jar:3.1.4.GA:test
...
[INFO] +- org.jboss.resteasy:resteasy-jaxb-provider:jar:3.0.19.Final:test
[INFO] |  \- com.sun.xml.bind:jaxb-impl:jar:2.2.7:test
[INFO] |     +- com.sun.xml.bind:jaxb-core:jar:2.2.7:test
[INFO] |     |  +- javax.xml.bind:jaxb-api:jar:2.2.7:test
[INFO] |     |  \- com.sun.istack:istack-commons-runtime:jar:2.16:test
[INFO] |     \- com.sun.xml.fastinfoset:FastInfoset:jar:1.2.12:test
[INFO] |        \- javax.xml.bind:jsr173_api:jar:1.0:test
@htynkn
Copy link
Member

htynkn commented Apr 3, 2019

@ralf0131
Copy link
Contributor Author

jsr173_api seems BEA licensed, and according to previous discussion, it seems incompatible with Apache License.
I think we should either contact Nacos community to fix it, or exclude this dependency explicitly.

@ralf0131
Copy link
Contributor Author

I've filed an issue on Nacos community alibaba/nacos#1057. Given it is a test dependency I think we can try to quickly fix it by excluding it explicitly.

@ralf0131
Copy link
Contributor Author

[INFO] +- org.jboss.resteasy:resteasy-jaxb-provider:jar:3.0.19.Final:test
[INFO] |  \- com.sun.xml.bind:jaxb-impl:jar:2.2.7:test
[INFO] |     +- com.sun.xml.bind:jaxb-core:jar:2.2.7:test
[INFO] |     |  +- javax.xml.bind:jaxb-api:jar:2.2.7:test
[INFO] |     |  \- com.sun.istack:istack-commons-runtime:jar:2.16:test
[INFO] |     \- com.sun.xml.fastinfoset:FastInfoset:jar:1.2.12:test
[INFO] |        \- javax.xml.bind:jsr173_api:jar:1.0:test

Sorry, I have made a mistake. Actually the dependency is introduced by dubbo-registry-nacos, not on the Nacos side.

@ralf0131 ralf0131 added this to the 2.7.2 milestone Apr 23, 2019
@cvictory cvictory assigned asf-ci and mercyblitz and unassigned asf-ci May 6, 2019
This was referenced May 23, 2019
mercyblitz pushed a commit that referenced this issue Jun 26, 2019
* Polish apache/incubator-dubbo/#4096 : To add new module for Dubbo Event

* Polish #3942 : Dubbo Cloud Native: To Add Service registration and discovery abstract

* Polish #3946 : Dubbo Cloud Native : To Add Dubbo metadata service

* Polish #4093 : To add exported and unexported events for ServiceConfig

* Polish #3984 : Add Service registration and discovery implementation for Zookeeper

* Polish #4104 : To add initialized and destroyed events for ReferenceConfig

* Polish #3946 : Refactor Dubbo metadata service

* Polish #3946 : To Add MetadataServiceExporter into dubbo-config-api

* Update ${project.parent.version}

* Polish #3946 : Refactor Dubbo metadata service

* Polish apache/incubator-dubbo/#4096 : Remove the duplicated word

* Polish #4119 : DynamicConfiguration adds the publish and multiple get configuration methods

* Polish #4120 : To add DynamicConfiguration implementation for Zookeeper

* Polish #4121 : Add the mapping from service metadata to service name

* Polish apache/incubator-dubbo/#3790 : Dependencies with no license

* Polish #4071 : @reference can't match the local @service beans

* Update version to be 2.7.3

* Polish #3946 : Add thread-safe and performance optimization

* Polish #3946 : Add thread-safe and performance optimization

* Polish #3946 : Add thread-safe and performance optimization

* Update 2.7.3

* Polish #4104 : To add more events for dubbo-config-api

* Polish #3942 : Dubbo Cloud Native: To Add Service registration and discovery abstract

* Polish #3984 : Add Service registration and discovery implementation for Zookeeper

* Add Bootstrap

* Polish GA

* Polish #4050 : Dubbo Cloud Native : Add a mechanism to upgrade Dubbo services smoothly

* Polish #4093 : To add DubboServiceDestroyedEvent

* Polish #4050 : Dubbo Cloud Native : Reactor

* Polish #3946 : Remove SPI

* Polish #4265 : [Feature] Dubbo Cloud Native - Add Bootstrap

* Polish #4265 : [Feature] Dubbo Cloud Native - Add Bootstrap

* Polish #4265 : Add test dependencies

* Polish /#3942 : Refactor implementation

* Polish #3984 : Refactor

* Add Nacos implementation

* Polish #3984 : Add Nacos implementation

* Polish #4268 : Dubbo Event - To support Generic event type handle

* Polish #4268 : Update JavaDoc

* Polish #4268 : Add GenericEventListener implementation

* add cache for MetadataServiceProxy

* support multiple metadata and configcenter

* unify metadata implementation

* add missed files

* remove duplicated files

* add new SPIs and modules to dubbo-all pom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants