-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web console: Make array ingest mode ux better #15927
Web console: Make array ingest mode ux better #15927
Conversation
What happens when you click on that? does it explain what the settings do? (IMO it should, since the behavior is potentially confusing. "array ingest mode: array" or "array ingest mode: MVD" might make people think they are definitely getting arrays or MVDs, but that's not how it works; it just controls what happens for things with SQL type |
I am not sure what There is this toggle in the UX flow that is on by default: It has this info section: (This was added before this PR) In the Run bar dropdown there is a link to the docs: Which links to https://druid.apache.org/docs/latest/querying/arrays/#differences-between-arrays-and-multi-value-dimensions |
@vogievetsky -- sorry, by "that" I meant the "array ingest mode" dropdown. I see it now in the screenshot. I just updated with new docs for Some flavor text for
And for mvd:
With the "? Documentation" link pointing to https://druid.apache.org/docs/latest/querying/arrays#arrayingestmode for the full details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits:
ARRAY<STRING>
is more typical formatting thanARRAY<string>
- multi-value
STRING
is better thanmulti-value STRING
. (the "multi-value" isn't an identifier that needs to be code-formatted, it's just English)
I am good with this, though, so, approving. But feel free to make those changes 😄
Thanks for the feedback I was going back and forth on that second point. I guess I manifested my inner wishes that Druid did have a |
* only set arrayIngestMode: array when needed (still do the queries the correct way) * arrayIngestMode control * update wording * feedback fixes
* only set arrayIngestMode: array when needed (still do the queries the correct way) * arrayIngestMode control * update wording * feedback fixes Co-authored-by: Vadim Ogievetsky <[email protected]>
This PR tries to address an issue of "web console tab context poisoning" that is when a web console user re-uses a tab by deleting the SQL query in the tab and writing/pasting a new one. The user might forget that deleting all the SQL does not clear the context parameters which will be attached to subsequent queries issued.
Specifically here is a scenario that is of concern:
arrayIngestMode: array
set (as was added in Web console: use arrayIngestMode: array #15588)arrayIngestMode: array
is still set in the query context in that tab.This PR makes two changes (in two respective commits):
arrayIngestMode: array
context parameter is only set when the user has opted in to arrays (via the toggle that is off by default). CurrentlyarrayIngestMode: array
is always being set by all UI flows and the toggle only affects the SQL that is generated.This change affects:
arrayIngestMode: array
is only set if the ingestion spec is detected as using arrays by having dimensions specs of type "auto" + "castToType: ARRAY<...>")arrayIngestMode
selection more prominent in the UI so that it is shown on the "Run panel" and is not hidden inside of a menu.