use NullFilter for SQL rewrite of MV_CONTAINS and MV_OVERLAP for null array elements #15855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagarwal87
approved these changes
Feb 7, 2024
abhishekagarwal87
approved these changes
Feb 7, 2024
LakshSingla
pushed a commit
to LakshSingla/druid
that referenced
this pull request
Feb 8, 2024
… array elements (apache#15855) Fixes an oversight after apache#14542 that happens in the SQL planner rewrite of MV_CONTAINS and MV_OVERLAP when faced with array elements that are NULL, where we were incorrectly using EqualityFilter instead of NullFilter for null elements (EqualityFilter does not accept null elements).
abhishekagarwal87
pushed a commit
that referenced
this pull request
Feb 8, 2024
… array elements (#15855) (#15865) Fixes an oversight after #14542 that happens in the SQL planner rewrite of MV_CONTAINS and MV_OVERLAP when faced with array elements that are NULL, where we were incorrectly using EqualityFilter instead of NullFilter for null elements (EqualityFilter does not accept null elements). Co-authored-by: Clint Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an oversight after #14542 that happens in the SQL planner rewrite of
MV_CONTAINSandMV_OVERLAPwhen faced with array elements that areNULL, where we were incorrectly usingEqualityFilterinstead ofNullFilterfor null elements (EqualityFilterdoes not accept null elements).Without the changes of this PR, the added tests would fail with errors like:
This PR has: