Web console: Don't force waitUntilSegmentLoad to true #15781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
approved these changes
Jan 31, 2024
LakshSingla
pushed a commit
to LakshSingla/druid
that referenced
this pull request
Feb 7, 2024
* Don't force setting waitUntilSegmentsLoad * delete irrelevant code
abhishekagarwal87
pushed a commit
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where waitUntilSegmentLoad would always be set to true even if explicitly set by the user to false. (1st commit)
Delete (and simplify) the logic where the console would wait for segments to be loaded in JS. 🙌 (2nd commit)