Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with nested virtual column index supplier for partial paths when processing from raw #15643

Conversation

clintropolis
Copy link
Member

Description

Fixes an issue when filtering NestedFieldVirtualColumn using 'processFromRaw' (e.g. JSON_QUERY instead of JSON_VALUE) when using partial paths. NestedFieldVirtualColumn was incorrectly returning null from getIndexSupplier in this case instead of NoIndexesColumnIndexSupplier.getInstance() to instruct the processing to fall back to using value matchers. Added test case for this, as well as another similar case which was working correctly where it should also fall back to using no-indexes when referring to an array element, to ensure no future regressions.


This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@clintropolis clintropolis force-pushed the fix-nested-virtual-column-index-supplier-partial-path-raw branch from 0461422 to d662f89 Compare January 9, 2024 00:10
@abhishekagarwal87 abhishekagarwal87 merged commit 911941b into apache:master Jan 9, 2024
83 checks passed
@clintropolis clintropolis deleted the fix-nested-virtual-column-index-supplier-partial-path-raw branch January 9, 2024 02:39
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants