Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorate sampling response with system fields if specified #15536

Merged

Conversation

zachjsh
Copy link
Contributor

@zachjsh zachjsh commented Dec 11, 2023

Description

#15276 added the ability to consume system fields from certain input sources. These
systemField values were previously however not being properly decorated in the sampling response, not allowing the user to sample ingest data whose value depends on the values of such systemFields. This pr fixes this issue.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@gianm gianm merged commit 857693f into apache:master Dec 13, 2023
83 checks passed
@zachjsh zachjsh deleted the decorate-sample-response-with-system-fields branch December 13, 2023 22:04
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants