-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make numCorePartitions
as 0 for tombstones
#15379
Merged
abhishekrb19
merged 5 commits into
apache:master
from
abhishekrb19:make_tombstone_core_partitions_0
Nov 20, 2023
Merged
Make numCorePartitions
as 0 for tombstones
#15379
abhishekrb19
merged 5 commits into
apache:master
from
abhishekrb19:make_tombstone_core_partitions_0
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekrb19
changed the title
WIP: Make
Make Nov 16, 2023
numCorePartitions
as 0 in TombstoneShardSpec
numCorePartitions
as 0 for tombstones
server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java
Show resolved
Hide resolved
AmatyaAvadhanula
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abhishekrb19! LGTM
Conceptually, the change makes sense to me but taking another pass just to be sure that it doesn't break any existing assumption in the code. Also, there are a couple of test failures. |
Thanks for the reviews! |
writer-jill
pushed a commit
to writer-jill/druid
that referenced
this pull request
Nov 20, 2023
* Make numCorePartitions as 0 in the TombstoneShardSpec. * fix up test * Add tombstone core partition tests * review comment * Need to register the test shard type to make jackson happy
6 tasks
yashdeep97
pushed a commit
to yashdeep97/druid
that referenced
this pull request
Dec 1, 2023
* Make numCorePartitions as 0 in the TombstoneShardSpec. * fix up test * Add tombstone core partition tests * review comment * Need to register the test shard type to make jackson happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the core partitions for tombstones to 0, so they can exist independently if they're deleted or marked as unused without affecting availability of other appended segments in the same co-partition space. This is particularly important in the following scenarios:
Release note
Tombstone segments now have 0 core partitions instead of 1. This means they can be dropped or removed independently without affecting availability of other appended segments in the same co-partition space. Note that removing tombstones with 1 core partition (prior to this change) that contain appended segments in the partition space can make the appended segments unavailable.
Key changed/added classes in this PR
TombstoneShardSpec.java
IndexerSQLMetadataStorageCoordinatorTest.java
This PR has: