Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved web-console's time-chart brush and added auto-granularity #14990

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Improved web-console's time-chart brush and added auto-granularity #14990

merged 5 commits into from
Nov 27, 2023

Conversation

lorem--ipsum
Copy link
Contributor

@lorem--ipsum lorem--ipsum commented Sep 14, 2023 •
edited
Loading

web-console.mp4

Changes:

  • added the notion of timezone in the explore view (not necessarily propagated everywhere and Etc/UTC for now, but still)
  • added chronoshift as a dependency
  • time chart is now able to automatically pick a granularity if "auto" is selected (which is the default) based on the current time filter extent
  • brush is now automatically enabled in the time chart
  • brush interval snaps to the selected time granularity
  • added a highlight bubble to all visualizations (except table because it has its own)

@jgoz
Copy link
Contributor

jgoz commented Sep 18, 2023

I think you need to run the script/licences script in the web-console directory so that the root licenses.yaml file gets updated.

jgoz
jgoz reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@jgoz jgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't go through it too deeply, but it looks cool! Just a couple minor comments

web-console/src/views/explore-view/modules/pie-chart-echarts-module.ts Outdated Show resolved Hide resolved
web-console/src/views/explore-view/utils/use-resize-observer.ts Outdated Show resolved Hide resolved
@jgoz
Copy link
Contributor

jgoz commented Sep 18, 2023

I think you accidentally use-resize-observer.ts

@lorem--ipsum lorem--ipsum force-pushed the time-chart-brush-improvements branch from 8ff7dda to 429ea9d Compare September 22, 2023 10:35
@lorem--ipsum lorem--ipsum force-pushed the time-chart-brush-improvements branch from 429ea9d to d5fb334 Compare October 9, 2023 14:50
@vogievetsky vogievetsky merged commit c8eb7ad into apache:master Nov 27, 2023
81 checks passed
@lorem--ipsum lorem--ipsum deleted the time-chart-brush-improvements branch November 28, 2023 13:21
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
@lorem--ipsum
Improved web-console's time-chart brush and added auto-granularity (a…
a7a68c4 
…pache#14990)

* Improved time-chart brush and added auto-granularity

* prettier

* added highlight bubble to explore visualizations

* Added licenses and fixes from PR review

* added missing files...
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
@lorem--ipsum
Improved web-console's time-chart brush and added auto-granularity (a…
05ef6c5 
…pache#14990)

* Improved time-chart brush and added auto-granularity

* prettier

* added highlight bubble to explore visualizations

* Added licenses and fixes from PR review

* added missing files...
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
@LakshSingla LakshSingla mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogievetsky vogievetsky vogievetsky approved these changes

@jgoz jgoz jgoz approved these changes

Assignees
No one assigned
Labels
Area - Dependencies Area - Web Console
Projects
None yet
Milestone
29.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lorem--ipsum @jgoz @vogievetsky @LakshSingla