fix NPE that can happen when merging all null nested v4 format columns #14068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imply-cheddar
approved these changes
Apr 11, 2023
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Apr 13, 2023
clintropolis
added a commit
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes another regression related to #14014, this time when processing all null or nonexistent columns with the 'json' (v4) format. Added a test to ensure that non-existent data is processed correctly, and tests for explicit 'auto' dimension schema with non-existent columns to ensure new common format also doesn't have any issues with non-existent columns.
This PR has: