Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: add a nice UI for overlord dynamic configs and improve the docs #13993

Merged
merged 41 commits into from
Mar 31, 2023

Conversation

vogievetsky
Copy link
Contributor

Add a nice form (with JSON fallback) to the overlord dynamic config dialog

image

To do this I had to read the docs and found them lacking. I asked @kfaraz to help me make heads and tails of the logic. Here was his summary that I rewrote in the docs.

Here are his original notes (screenshot form Slack DM):

image

If there are better way to word it I am all ears.

Copy link
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vad! Mostly minor grammatical fixes. There were some remaining inconsistencies with categoryConfig and some other properties showing up in multiple forms: categoryConfig, CategoryConfig, and categoryConfig. They should all typically be like categoryConfig (literal name in code font). I think we caught them all between your fixes and my suggestions.

docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
vogievetsky and others added 17 commits March 29, 2023 21:00
Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes, @vogievetsky. The document is much more pleasant to read now. The changes look good to me overall. I have just left some minor suggestions.

docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
@kfaraz
Copy link
Contributor

kfaraz commented Mar 30, 2023

Tried out the new console changes, the Overlord config is very easy to use now!
Encountered a minor bug. The content in the suggestion box seems to overflow in some cases.

Screenshot 2023-03-30 at 5 17 34 PM

@fjy fjy merged commit 981662e into apache:master Mar 31, 2023
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants