-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web console: add a nice UI for overlord dynamic configs and improve the docs #13993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vad! Mostly minor grammatical fixes. There were some remaining inconsistencies with categoryConfig and some other properties showing up in multiple forms: categoryConfig, CategoryConfig, and categoryConfig
. They should all typically be like categoryConfig
(literal name in code font). I think we caught them all between your fixes and my suggestions.
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
Co-authored-by: 317brian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the changes, @vogievetsky. The document is much more pleasant to read now. The changes look good to me overall. I have just left some minor suggestions.
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Co-authored-by: Kashif Faraz <[email protected]>
Add a nice form (with JSON fallback) to the overlord dynamic config dialog
To do this I had to read the docs and found them lacking. I asked @kfaraz to help me make heads and tails of the logic. Here was his summary that I rewrote in the docs.
Here are his original notes (screenshot form Slack DM):
If there are better way to word it I am all ears.