Update OIDCConfig with scope information #13973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| { | ||
| this.clientID = Preconditions.checkNotNull(clientID, "null clientID"); | ||
| this.clientSecret = Preconditions.checkNotNull(clientSecret, "null clientSecret"); | ||
| this.discoveryURI = Preconditions.checkNotNull(discoveryURI, "null discoveryURI"); | ||
| this.scope = Preconditions.checkNotNull(scope, "null scope"); |
There was a problem hiding this comment.
null scope should be allowed or otherwise existing installations will break.
There was a problem hiding this comment.
thanks for pointing out, updated.
|
you may need to update the docs as well. |
There was a problem hiding this comment.
default scope is "openid profile email" from what I can tell looking in the lib.
There was a problem hiding this comment.
thanks for the feedback, I will update the docs.
Where did you find the default value?
There was a problem hiding this comment.
abhishekagarwal87
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates OIDCConfig class with scope information
Set scope for OIDCConfiguration object
This PR has: