Minor: improve TableReference docs #9952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
approved these changes
Apr 4, 2024
Jefffrey
approved these changes
Apr 5, 2024
| @@ -139,7 +142,7 @@ impl TableReference { | |||
|
|
|||
| /// Convenience method for creating a [`TableReference::Partial`]. | |||
| /// | |||
| /// As described on [`TableReference`] this does *NO* parsing at all. | |||
| /// As described on [`TableReference`] this does *NO* normalization at all. | |||
There was a problem hiding this comment.
nit: technically the doc on TableReference doesn't make reference to partial or full functions as it only refers to bare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #9933 from @comphead I noticed a few things that could be improved in the docs
What changes are included in this PR?
Improve
TableReferencdocsAre these changes tested?
Doc tests
Are there any user-facing changes?
Better docs