Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(7181): move streaming_merge() into separate mod from the merge node #7799

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

wiedld
Copy link
Contributor

@wiedld wiedld commented Oct 11, 2023

Which issue does this PR close?

Prerequisite for the cascading merge.
Part of #7181 .

Rationale for this change

Create a new merge submodule which has the SortPreservingMergeStream (a.k.a. the loser tree). The SortPreservingMergeStream will be used repeatedly as part of the cascading merge tree.

By comparison, the streaming_merge() method will only be called once -- by the cascading struct (in the cascade submodule).

What changes are included in this PR?

See above.

Are these changes tested?

Only moving code. Nothing change.

Are there any user-facing changes?

No.

…ge mod.

Merge mod has the SortPreservingMergeStream, containing the loser tree. This SortPreservingMergeStream struct will be used repeatedly as part of the cascading merge; in turn, the cascading merge will be implemented for the streaming_merge() method.
@wiedld wiedld marked this pull request as ready for review October 11, 2023 22:41
@tustvold tustvold merged commit 20bc365 into apache:main Oct 13, 2023
22 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 13, 2023

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants