Upgrade to sqlparser 0.53.0
#13767
Upgrade to sqlparser 0.53.0
#13767
Conversation
github-actions
bot
added
sql
alamb
force-pushed
the
alamb/sqlparser_0.53.0
branch
from
6dc5055 to
3e521f1
Compare
| @@ -200,7 +204,6 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| statement: Statement, | |||
| planner_context: &mut PlannerContext, | |||
| ) -> Result<LogicalPlan> { | |||
| let sql = Some(statement.to_string()); | |||
There was a problem hiding this comment.
This change was needed because otherwise tpcds_logical_q64 overflowed its stack
https://github.com/apache/datafusion/actions/runs/12322166828/job/34395679472?pr=13767
thread 'tpcds_logical_q64' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
I traced it down locally and apparently trying to format the deeply nested query was actually overflowing at this spot.
| @@ -514,6 +517,35 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| return not_impl_err!("To not supported")?; | |||
| } | |||
|
|
|||
| // put the statement back together temporarily to get the SQL | |||
There was a problem hiding this comment.
While this formulation is more code, it does avoid serializing the entire input string on every query, even when it is not needed
| @@ -313,7 +313,7 @@ pub enum Expr { | |||
| /// plan into physical plan. | |||
| Wildcard { | |||
| qualifier: Option<TableReference>, | |||
| options: WildcardOptions, | |||
| options: Box<WildcardOptions>, | |||
There was a problem hiding this comment.
This was needed to avoid a clippy lint about enum variants being too different. Specifically sqlparser added some new fields to WildCardOptions which made them substantially larger
alamb
force-pushed
the
alamb/sqlparser_0.53.0
branch
from
239c18e to
1e8d072
Compare
alamb
force-pushed
the
alamb/sqlparser_0.53.0
branch
from
1e8d072 to
bd101da
Compare
alamb
force-pushed
the
alamb/sqlparser_0.53.0
branch
from
504c04d to
3ae39a5
Compare
| } => self.show_columns_to_plan(extended, full, table_name, filter), | ||
| show_options, | ||
| } => { | ||
| let ShowStatementOptions { |
There was a problem hiding this comment.
Thanks for this checks @alamb I'm wondering if it caused by sql parser API extension or it technical debt?
There was a problem hiding this comment.
It was caused by changes in the SQL Parser AST -- specifically I think it was introduced in
|
Thanks for the reviews @comphead (as always). Let's keep this code flowing 🚀 |
Which issue does this PR close?
Rationale for this change
Keep up with dependencies (in this case get access to source spans)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?