Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock lexical-write-integer version. #13693

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Unlock lexical-write-integer version. #13693

merged 1 commit into from
Dec 9, 2024

Conversation

Alexhuszagh
Copy link
Contributor

Issue was patched as of lexical release 1.0.5.

Reverts #13689
Closes #13686

@Alexhuszagh
Unlock lexical-write-integer version.
9d7b2c4 
Issue was patched as of lexical release 1.0.5.

Reverts apache#13689
Closes apache#13686
@github-actions github-actions bot added the core Core DataFusion crate label Dec 8, 2024
@Alexhuszagh
Copy link
Contributor Author

I only tested this locally with the failing datasource::physical_plan::json::tests::test_chunked_json tests, but it should be the same with all the remaining errors. My test machine doesn't have enough RAM to link the entire core test suite, so I was only able to test these updates while commenting out some of the other tests.

@alamb alamb mentioned this pull request Dec 8, 2024
Closed
@alamb
Copy link
Contributor

alamb commented Dec 8, 2024 •
edited
Loading

Thank you @Alexhuszagh -- I started off the CI on the runners.

jonahgao
jonahgao approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Alexhuszagh

@jonahgao jonahgao merged commit 47569b2 into apache:main Dec 9, 2024
27 checks passed
zhuliquan pushed a commit to zhuliquan/datafusion that referenced this pull request Dec 11, 2024
@Alexhuszagh @zhuliquan
Unlock lexical-write-integer version. (apache#13693)
e8226f5 
Issue was patched as of lexical release 1.0.5.

Reverts apache#13689
Closes apache#13686
zhuliquan pushed a commit to zhuliquan/datafusion that referenced this pull request Dec 15, 2024
@Alexhuszagh @zhuliquan
Unlock lexical-write-integer version. (apache#13693)
7728525 
Issue was patched as of lexical release 1.0.5.

Reverts apache#13689
Closes apache#13686
@alamb alamb mentioned this pull request Dec 17, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgao jonahgao jonahgao approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failed due to the dependency lexical-write-integer upgrade
3 participants
@Alexhuszagh @alamb @jonahgao