Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashbrown requirement from 0.14.5 to 0.15.1 #13256

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 5, 2024

Updates the requirements on hashbrown to permit the latest version.

Changelog

Sourced from hashbrown's changelog.

[v0.15.1] - 2024-11-03

This release removes the borsh feature introduced in 0.15.0 because it was found to be incorrectly implemented. Users should use the hashbrown feature of the borsh crate instead which provides the same trait implementations.

[v0.15.0] - 2024-10-01

This release was yanked due to a broken implementation of the borsh feature.

This update contains breaking changes that remove the raw API with the hope of centralising on the HashTable API in the future. You can follow the discussion and progress in #545 to discuss features you think should be added to this API that were previously only possible on the raw API.

Added

  • Added borsh feature with BorshSerialize and BorshDeserialize impls. (#525)
  • Added Assign impls for HashSet operators. (#529)
  • Added Default impls for iterator types. (#542)
  • Added HashTable::iter_hash{,_mut} methods. (#549)
  • Added Hash{Table,Map,Set}::allocation_size methods. (#553)
  • Implemented Debug and FusedIterator for all HashTable iterators. (#561)
  • Specialized Iterator::fold for all HashTable iterators. (#561)

Changed

  • Changed hash_set::VacantEntry::insert to return OccupiedEntry. (#495)
  • Improvedhash_set::Difference::size_hint lower-bound. (#530)
  • Improved HashSet::is_disjoint performance. (#531)
  • equivalent feature is now enabled by default. (#532)
  • HashSet operators now return a set with the same allocator. (#529)
  • Changed the default hasher to foldhash. (#563)
  • ahash feature has been renamed to default-hasher. (#533)
  • Entry API has been reworked and several methods have been renamed. (#535)
  • Hash{Map,Set}::insert_unique_unchecked is now unsafe. (#556)
  • The signature of get_many_mut and related methods was changed. (#562)

Fixed

  • Fixed typos, stray backticks in docs. (#558, #560)

Removed

  • Raw entry API is now under raw-entry feature, to be eventually removed. (#534, #555)
  • Raw table API has been made private and the raw feature is removed; in the future, all code should be using the HashTable API instead. (#531, #546)
  • rykv feature was removed; this is now provided by the rykv crate instead. (#554)
  • HashSet::get_or_insert_owned was removed in favor of get_or_insert_with. (#555)

... (truncated)

Commits
  • dd56b3b Merge pull request #581 from Amanieu/release-0.15.1
  • 5643b13 Yank v0.15.0
  • 986305a Merge pull request #582 from Amanieu/stable-strict-provenance
  • 1295e3e Remove mentions of stabilized feature strict_provenance
  • 458e445 Release v0.15.1
  • ccec5eb Merge pull request #580 from Kobzol/ci-doc
  • 02ddcc9 Document conclusion job more
  • 998637f Merge pull request #575 from Kobzol/ci-remove-bors
  • c6b90d9 Switch from using Bors to merge queue in CI
  • eea9804 Auto merge of #572 - cuviper:ci-msrv, r=Amanieu
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@findepi
Copy link
Member

findepi commented Nov 5, 2024

versions that meet the requirements `^0.15.1` are: 0.15.1

the package `datafusion-common` depends on `hashbrown`, with features: `raw` but `hashbrown` does not have these features.

@crepererum
Copy link
Contributor

I think raw shouldn't be used anymore (already in 0.14). I think we might get away with a migration that is similar to apache/arrow-rs#6537

@crepererum
Copy link
Contributor

This is blocked by #13433.

@alamb alamb marked this pull request as draft November 15, 2024 18:33
@dependabot dependabot bot force-pushed the dependabot/cargo/main/hashbrown-0.15.1 branch from d8538db to 673b56d Compare November 21, 2024 05:51
crepererum added a commit to crepererum/arrow-datafusion that referenced this pull request Nov 21, 2024
This is similar to `RawTableAllocExt` and will help apache#13256.
crepererum added a commit to crepererum/arrow-datafusion that referenced this pull request Nov 21, 2024
crepererum added a commit to crepererum/arrow-datafusion that referenced this pull request Nov 21, 2024
jayzhan211 pushed a commit that referenced this pull request Nov 22, 2024
)

* feat: add `HashTableAllocExt`

This is similar to `RawTableAllocExt` and will help #13256.

* refactor: convert `ArrowBytesMap` to `HashTable`

For #13256.

* refactor: convert `ArrowBytesViewMap` to `HashTable`

For #13256.
Updates the requirements on [hashbrown](https://github.com/rust-lang/hashbrown) to permit the latest version.
- [Changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md)
- [Commits](rust-lang/hashbrown@v0.14.5...v0.15.1)

---
updated-dependencies:
- dependency-name: hashbrown
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/main/hashbrown-0.15.1 branch from 673b56d to 445e991 Compare November 24, 2024 20:31
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 25, 2024

Superseded by #13557.

@dependabot dependabot bot closed this Nov 25, 2024
@dependabot dependabot bot deleted the dependabot/cargo/main/hashbrown-0.15.1 branch November 25, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants