Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-to-DF-42: Provide field and schema metadata missing on distinct aggregations #12975

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 16, 2024

Part of #12813

Rationale for this change

This PR is used to backport #12691 / #12687 to DF 42.

What changes are included in this PR?

PR #12691

Are these changes tested?

Yes, on main branch.

…pache#12691)

* test(12687): reproducer of missing metadata bug

* fix(12687): minimum change needed to fix the missing metadata
@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Oct 16, 2024
@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 16, 2024

cc @alamb and @matthewmturner for a look, thank you.

@alamb
Copy link
Contributor

alamb commented Oct 16, 2024

I believe CI will pass once we merge #12977 in. I will try and manage the PRs over the next few hours

@alamb
Copy link
Contributor

alamb commented Oct 16, 2024

Thank you @Xuanwo

@alamb
Copy link
Contributor

alamb commented Oct 16, 2024

close/reopen to trigger CI

@alamb alamb closed this Oct 16, 2024
@alamb alamb reopened this Oct 16, 2024
@matthewmturner
Copy link
Contributor

@alamb this one is good as well

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb
Copy link
Contributor

alamb commented Oct 16, 2024

I merged up from the branch-42 to resolve a conflict

@alamb alamb merged commit 0cab805 into apache:branch-42 Oct 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants