-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate sqllogictest for StringView (for one function, substr)
#12433
Merged
alamb
merged 2 commits into
apache:main
from
2010YOUY01:automate-sqllogictest-stringview
Sep 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136 changes: 136 additions & 0 deletions
136
datafusion/sqllogictest/test_files/string_functions/substr/substr_literal.slt.part
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', -3) | ||
| ---- | ||
| alphabet | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', 0) | ||
| ---- | ||
| alphabet | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', 1) | ||
| ---- | ||
| alphabet | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', 2) | ||
| ---- | ||
| lphabet | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', 3) | ||
| ---- | ||
| phabet | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', 30) | ||
| ---- | ||
| (empty) | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', 3, 2) | ||
| ---- | ||
| ph | ||
|
|
||
| query T | ||
| SELECT substr('alphabet', 3, 20) | ||
| ---- | ||
| phabet | ||
|
|
||
| query TT | ||
| select | ||
| substr(arrow_cast('alphabet', 'LargeUtf8'), 3, 20), | ||
| substr(arrow_cast('alphabet', 'Utf8View'), 3, 20); | ||
| ---- | ||
| phabet phabet | ||
|
|
||
| # test range ouside of string length | ||
| query TTTTTTTTTTTT | ||
| SELECT | ||
| substr('hi🌏', 1, 3), | ||
| substr('hi🌏', 1, 4), | ||
| substr('hi🌏', 1, 100), | ||
| substr('hi🌏', 0, 1), | ||
| substr('hi🌏', 0, 2), | ||
| substr('hi🌏', 0, 4), | ||
| substr('hi🌏', 0, 5), | ||
| substr('hi🌏', -10, 100), | ||
| substr('hi🌏', -10, 12), | ||
| substr('hi🌏', -10, 5), | ||
| substr('hi🌏', 10, 0), | ||
| substr('hi🌏', 10, 10); | ||
| ---- | ||
| hi🌏 hi🌏 hi🌏 (empty) h hi🌏 hi🌏 hi🌏 h (empty) (empty) (empty) | ||
|
|
||
| query TTTTTTTTTTTT | ||
| SELECT | ||
| substr('', 1, 3), | ||
| substr('', 1, 4), | ||
| substr('', 1, 100), | ||
| substr('', 0, 1), | ||
| substr('', 0, 2), | ||
| substr('', 0, 4), | ||
| substr('', 0, 5), | ||
| substr('', -10, 100), | ||
| substr('', -10, 12), | ||
| substr('', -10, 5), | ||
| substr('', 10, 0), | ||
| substr('', 10, 10); | ||
| ---- | ||
| (empty) (empty) (empty) (empty) (empty) (empty) (empty) (empty) (empty) (empty) (empty) (empty) | ||
|
|
||
| # Nulls | ||
| query TTTTTTTTTT | ||
| SELECT | ||
| substr('alphabet', NULL), | ||
| substr(NULL, 1), | ||
| substr(NULL, NULL), | ||
| substr('alphabet', CAST(NULL AS int), -20), | ||
| substr('alphabet', 3, CAST(NULL AS int)), | ||
| substr(NULL, 3, -4), | ||
| substr(NULL, NULL, 4), | ||
| substr(NULL, 1, NULL), | ||
| substr('', NULL, NULL), | ||
| substr(NULL, NULL, NULL); | ||
| ---- | ||
| NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL | ||
|
|
||
| query T | ||
| SELECT substr('Hello🌏世界', 5) | ||
| ---- | ||
| o🌏世界 | ||
|
|
||
| query T | ||
| SELECT substr('Hello🌏世界', 5, 3) | ||
| ---- | ||
| o🌏世 | ||
|
|
||
| statement error The SUBSTR function can only accept strings, but got Int64. | ||
| SELECT substr(1, 3) | ||
|
|
||
| statement error The SUBSTR function can only accept strings, but got Int64. | ||
| SELECT substr(1, 3, 4) | ||
|
|
||
| statement error Execution error: negative substring length not allowed | ||
| select substr(arrow_cast('foo', 'Utf8View'), 1, -1); | ||
|
|
||
| statement error Execution error: negative substring length not allowed | ||
| select substr('', 1, -1); |
72 changes: 72 additions & 0 deletions
72
datafusion/sqllogictest/test_files/string_functions/substr/substr_runner.slt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # -------------------------------------- | ||
| # Test `substr()` with literal arguments | ||
| # -------------------------------------- | ||
| include ./substr_literal.slt.part | ||
|
|
||
| # -------------------------------------- | ||
| # Setup test tables with different physical string types (Utf8/Utf8View/LargeUtf8) | ||
| # and repeat tests in `substr_table.slt.part` | ||
| # -------------------------------------- | ||
| statement ok | ||
| create table test_substr_base ( | ||
| col1 VARCHAR | ||
| ) as values ('foo'), ('hello🌏世界'), ('💩'), ('ThisIsAVeryLongASCIIString'), (''), (NULL); | ||
|
|
||
| # | ||
| # Run1: Utf8 | ||
| # | ||
| statement ok | ||
| create table test_substr as | ||
| select arrow_cast(col1, 'Utf8') as c1 from test_substr_base; | ||
|
|
||
| include ./substr_table.slt.part | ||
|
|
||
| statement ok | ||
| drop table test_substr; | ||
|
|
||
| # | ||
| # Run2: Utf8View | ||
| # | ||
| statement ok | ||
| create table test_substr as | ||
| select arrow_cast(col1, 'Utf8View') as c1 from test_substr_base; | ||
|
|
||
| include ./substr_table.slt.part | ||
|
|
||
| statement ok | ||
| drop table test_substr; | ||
|
|
||
| # | ||
| # Run3: LargeUtf8 | ||
| # | ||
| statement ok | ||
| create table test_substr as | ||
| select arrow_cast(col1, 'LargeUtf8') as c1 from test_substr_base; | ||
|
|
||
| include ./substr_table.slt.part | ||
|
|
||
| statement ok | ||
| drop table test_substr; | ||
|
|
||
| # -------------------------------------- | ||
| # Cleanup | ||
| # -------------------------------------- | ||
| statement ok | ||
| drop table test_substr_base; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a neat idea to break the literals as well into their own file