-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subquery alias table definition unparsing for SQLite #12331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
force-pushed
the
sgrebnov/sqlite-subquery-alias-fix
branch
from
September 5, 2024 05:45
4f5d93b
to
fb173a1
Compare
sgrebnov
force-pushed
the
sgrebnov/sqlite-subquery-alias-fix
branch
from
September 5, 2024 05:49
fb173a1
to
0dd2e68
Compare
Co-authored-by: Phillip LeBlanc <[email protected]>
Co-authored-by: Phillip LeBlanc <[email protected]>
phillipleblanc
approved these changes
Sep 5, 2024
alamb
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sgrebnov and @phillipleblanc -- this looks great to me
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SQLite does not support defining column aliases as part of alias table definition, for example
Must be rewritten as shown below so it can be executed on SQLite.
PRs address this issue by adding an option for unparser to specify column aliases as part of internal query projection instead of outer table alias definition.
TPC-H Q13 is an example of where such aliasing is used.
Rationale for this change
PR introduces
supports_column_alias_in_table_alias
parameter to control desired behavior and adds logic to produce the right SQL for SQLite dialect.The logic is applied only if column aliases are provided in the table alias definition and
supports_column_alias_in_table_alias
is set to false (not supported).What changes are included in this PR?
See above
Are these changes tested?
Tested manually and added unit tests.
Are there any user-facing changes?
PR introduces new dialect parameter
supports_column_alias_in_table_alias
that can be used to control the behavior of column aliasing in table aliasing.