Define current arrow_cast behavior for BinaryView #12200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiedld
force-pushed
the
dlw/tests-arrow-cast-binary-view
branch
from
aa4c24a to
5b43f04
Compare
alamb
approved these changes
Aug 28, 2024
|
I merged this PR up from main to get the latest changes and reran the sqllogictests to verify they still passed. Thanks again @wiedld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up to observation made on this PR.
Rationale for this change
Test coverage for current behavior of
arrow_castwith Utf8View and BinaryView types.The change needed is already in upstream arrow-cast, but not in the current release used in datafusion.
What changes are included in this PR?
Only test changes. No code changes.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.