Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Result.unwrap_or_else where applicable #12166

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 26, 2024

No description provided.

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions proto Related to proto crate labels Aug 26, 2024
Copy link
Member

@lewiszlw lewiszlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @findepi .

@findepi findepi force-pushed the findepi/use-result-unwrap-or-else-where-applicable-45d7b3 branch from 014de14 to e671835 Compare August 26, 2024 13:14
@github-actions github-actions bot removed sql SQL Planner logical-expr Logical plan and expressions labels Aug 26, 2024
@jonahgao
Copy link
Member

Thanks @findepi @lewiszlw

@jonahgao jonahgao merged commit 0c75ddd into apache:main Aug 26, 2024
24 checks passed
@findepi findepi deleted the findepi/use-result-unwrap-or-else-where-applicable-45d7b3 branch August 26, 2024 14:36
@findepi
Copy link
Member Author

findepi commented Aug 26, 2024

thank you @lewiszlw @jonahgao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proto Related to proto crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants