-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional regexp function regexp_count() #12080
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f72c11f
Implement regexp_ccount
xinlifoobar 682a50a
Merge branch 'main' of github.com:apache/datafusion into dev/xinli/re…
xinlifoobar ee23b97
Update document
xinlifoobar d5b63f4
fix check
xinlifoobar 2acd148
add more tests
xinlifoobar a3563ee
Merge branch 'main' of github.com:apache/datafusion into dev/xinli/re…
xinlifoobar 27a6fc6
Update the world to 1.80
xinlifoobar d17e45d
Fix doc format
xinlifoobar ee14adf
Add null tests
xinlifoobar 08343dd
Add uft8 support and bench
xinlifoobar 218ff7b
Refactoring regexp_count
xinlifoobar 0333ec4
Merge branch 'main' of github.com:apache/datafusion into dev/xinli/re…
xinlifoobar 07312be
Refactoring regexp_count
xinlifoobar 4eb7e6b
Revert ci change
xinlifoobar cb13556
Fix ci
xinlifoobar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to do this for
StringArrayType
. Maybe we should consider relocating it to a common package?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be very open to moving the StringArrayType, StringArrayBuilder, StringViewArrayBuilder, etc to a file in functions such as string_array.rs as they are used in multiple modules (unicode, regex, likely datetime in the future, etc) and are quite useful in general for any external UDF that might need them.