Minor: Extract BatchCoalescer to its own module
#12047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 18, 2024
| @@ -365,511 +335,3 @@ impl RecordBatchStream for CoalesceBatchesStream { | |||
| self.coalescer.schema() | |||
| } | |||
| } | |||
|
|
|||
| /// Concatenate multiple record batches into larger batches | |||
There was a problem hiding this comment.
The point of this PR is to move this code into its own module
alamb
commented
Aug 18, 2024
| @@ -346,7 +316,7 @@ impl CoalesceBatchesStream { | |||
| } | |||
| CoalesceBatchesStreamState::Exhausted => { | |||
| // Handle the end of the input stream. | |||
| return if self.coalescer.buffer.is_empty() { | |||
| return if self.coalescer.is_empty() { | |||
There was a problem hiding this comment.
Putting the BatchCoalescer into its own module means this code must use an accessor rather than directly look at the coalescer's state, which I think improves the modularity (a tiny bit)
| /// combined filter/coalesce operation. | ||
| /// | ||
| #[derive(Debug)] | ||
| pub struct BatchCoalescer { |
There was a problem hiding this comment.
The only changes in this module are to make the struct's and some methods pub and update the documentation slightly
11 tasks
alamb
force-pushed
the
alamb/coalesce_docs
branch
from
6e9a036 to
3f9bf97
Compare
|
Will review tomorrow 🚀 |
|
Thank you for the review @ozankabak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7957 and #11628
Rationale for this change
I have hopes to improve how coalesce batches works in DataFusion saving a copy to improve performance, partly by avoiding the need for
CoalesceBatchesExecPart of this is to use the
BatchCoalescermore, so let's pull it into its own module. This also makes the code boundaries a bit clearer (e.g. the functions that form the public interface now must be markedpub)What changes are included in this PR?
BatchCoalescerto its own moduleAre these changes tested?
By existing CI
Are there any user-facing changes?
No functional changes