Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StringView support for SUBSTR #12044

Merged
merged 27 commits into from
Sep 6, 2024
Merged

Improve StringView support for SUBSTR #12044

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
44894e1
operate stringview instead of generating string in SUBSTR
Kev1n8 Aug 17, 2024
4810be9
treat Utf8View as Text in sqllogictests output
Kev1n8 Aug 17, 2024
e8854b8
add bench to see enhancement of utf8view against utf8 and large_utf8
Kev1n8 Aug 17, 2024
35e4658
fix a tiny bug
Kev1n8 Aug 17, 2024
bf6c37e
make clippy happy
Kev1n8 Aug 17, 2024
74acc7c
add tests to cover stringview larger than 12B and correct the code
Kev1n8 Aug 17, 2024
af795a4
better comments
Kev1n8 Aug 17, 2024
f8989d2
fix lint
Kev1n8 Aug 17, 2024
26a878a
correct feature setting
Kev1n8 Aug 17, 2024
2d8458e
avoid expensive utf8 and some other checks
Kev1n8 Aug 18, 2024
934516a
fix lint
Kev1n8 Aug 18, 2024
48e1643
remove unnecessary indirection
Kev1n8 Aug 18, 2024
6ff32fc
add optimized_utf8_to_str_type
Kev1n8 Aug 18, 2024
9537c47
Simplify type check
alamb Aug 19, 2024
5356b27
Use ByteView
alamb Aug 19, 2024
bef80cb
Merge pull request #1 from alamb/alamb/cleanup_substr
Kev1n8 Aug 20, 2024
118aaba
Merge remote-tracking branch 'apache/main' into stringview-output-for…
alamb Aug 21, 2024
b4e1ac7
update datafusion-cli.lock
alamb Aug 21, 2024
7106ef2
Remove duration override
alamb Aug 21, 2024
28d6aca
format toml
alamb Aug 21, 2024
3be3553
refactor the code, using append_view_u128 from arrow
Kev1n8 Aug 23, 2024
b288605
manually collect the views and nulls
Kev1n8 Aug 23, 2024
e2643f9
remove bench file and fix some comments
Kev1n8 Aug 23, 2024
f462bbb
fix tiny mistake
Kev1n8 Aug 23, 2024
12e878c
Merge remote-tracking branch 'apache/main' into stringview-output-for…
alamb Aug 25, 2024
9320e41
Merge remote-tracking branch 'apache/main' into stringview-output-for…
alamb Sep 5, 2024
2c88a19
Update Cargo.lock
alamb Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ arrow = { version = "52.2.0", features = [
arrow-array = { version = "52.2.0", default-features = false, features = [
"chrono-tz",
] }
arrow-data = { version = "52.2.0", default-features = false }
arrow-buffer = { version = "52.2.0", default-features = false }
arrow-flight = { version = "52.2.0", features = [
"flight-sql-experimental",
Expand Down
Loading
Loading